Repository navigation
Conversation
Deicyde
added
the
awaiting author
meta-cla
Bot
added
the
CLA Signed
|
Replacement-branch review is BLOCKED at |
TreeSnapshot.materialize and materialize_regular_files wrote a captured tree below a fresh directory with descriptor-relative mkdir and O_EXCL writes, captured the result again to check it, and cleaned up after a failure. They reached main with facebookresearch#95, and no production code on main has ever called them: git log -S '.materialize(' is empty, and git log -S materialize_regular_files finds only the three facebookresearch#95 commits that added and hardened it with its tests. The callers lived only on pull requests that never merged: facebookresearch#8 and facebookresearch#70, facebookresearch#34 and facebookresearch#72, facebookresearch#36 and facebookresearch#69, facebookresearch#38 and facebookresearch#74, and facebookresearch#145. render writes its private copy of the blueprint with _private_copy, and project new has its own _materialize_project. Delete both methods, the eleven helpers only they reached (_materialization_parts through _cleanup_materialization), the _WRITE_FILE_FLAGS, _DESCRIPTOR_MATERIALIZATION_SUPPORTED and _WINDOWS_DEVICE_NAMES constants, and the two checkpoint events only they emitted. Delete _synthetic_snapshot and the eight test_snapshot_materialization_* tests, which covered nothing else, and the TreeSnapshot import they leave unused. unsupported_entries stays, with the _special_file_kind it uses: lean.py and render.py call it to refuse links and special files. _normalized_name, _close_descriptor, _stat_signature, _stable_entry_identity, capture_directory_descriptor and the checkpoint hook keep their other users. The deleted code was the last production code to set TreeCaptureLimits.max_depth and max_file_bytes, and the only reader besides revision of TreeSnapshot.placeholders and opaque_directories; the next commits remove those. TreeSnapshot keeps every field, and no capture path changes, so no digest, revision, JSON output or CLI behavior changes.
1 participant
Moved from #36. Its head branch lived on VivienCabannes/autoform-bot, which is being deleted, so this PR uses the same-named branch in facebookresearch/autoform-bot (same commits, head 16a3033). Earlier review and discussion are on #36.
Summary
.ilean,.olean, and.traceartifactsmathlib: trueclaims until the separate Mathlib provenance slice landsThis builds on #28.
Validation