Repository navigation
Conversation
The checks for missing article IDs and missing article revisions each repeated the same dispatchable, non-Mathlib, unproved filter over the runtime nodes. Both now read one list of unfinished leaves, and raise the same errors in the same order.
_owners and _descends_from each walked a constant's parent chain with the same cycle guard. The walk is now one generator, _ancestors, and both of its uses still stop at the first matching parent.
_report_kind and _report_withheld each had one caller, _report_entry. Their checks now sit where each field is read, with the same messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #92 and #136. No behaviour change: 3 files, +18/-42, one commit per item.
work.py,list_ready_work). The checks for missing article IDs and missing article revisions each repeated the same dispatchable, non-Mathlib, unproved filter over the runtime nodes. Both now read one list, and raise the same errors in the same order._ancestors(impact.py)._ownersand_descends_fromeach walked a constant'sparentchain with the same cycle guard. The walk is now one generator._ownersstill returns at the first parent an article names, andname in _ancestors(...)stops at the first match, as_descends_fromdid._report_entry(skeleton.py)._report_kindand_report_withheldeach had one caller. Their checks now sit where each field is read, with the same messages.Noticed, not changed:
_report_entry. The withheld-flag error is covered.Overlaps with open PRs:
work impactworking beside Lean files whose names are not identifiers #182 and Allow proof imports with measured impact #183 editimpact.pyandskeleton.py, Deploy Pages only after autoform verify passes, and refuse a lean: name defined twice #140 and Bind statement: formalized to a recorded statement_hash #141 edit all three files, and Add verified statement-review bundles #75 editsskeleton.py.open-statements-revision, which conflicts with main.Validation at exact head
ac4a5148:ruff check autoform_cli servers testsis clean.tests/test_work.py(30),tests/test_impact.py(73),tests/test_contract.py(2) andtests/test_cli.py(5) pass. Without Lean onPATH,tests/test_skeleton.pygives 144 passed and 28 skipped. CI's real-Lean job runs the other 28. With Lean installed, all 172 passed locally with thisskeleton.pychange applied to main.