Repository navigation
Bring CONTRIBUTING and the CLI reference in line with main - #149
Merged
Merged
Conversation
CONTRIBUTING.md was still the unedited template: a "..." placeholder for the development process, 2-space and 80-column style rules, and a blank project name in the license section. It now lists the make targets CI runs, the style rules the repository uses (ruff check with default rules, the 120-character line length from pyproject.toml, no formatter), and the project name. Two passages in the CLI reference named the deprecated worker stack after a GitHub account. The doctor section now says "a future worker fleet". The claim section's sentence about those workers is removed: it said their continue-uncoordinated failure behavior must go before they use the claim API, but the execution branch's scheduler already uses ClaimBoard and fails closed. The commands section now says the PATH form assumes the Python package is installed, which until now only the README said, and that a consumer project lacks the package, not the plugin whose root it then resolves.
The Windows job runs all of tests/test_project_inspect.py, not only part of tests/test_skeleton.py, and the real-Lean job also runs one tests/test_project_inspect.py test. Only the tests/test_skeleton.py real-Lean tests skip when the pinned toolchain is missing; the real-Lake tests in tests/test_lake_artifact_audit.py and tests/test_project_inspect.py skip only without lake, and elan downloads the toolchain for them. Ruff's default rules leave out E501, so the 120-character limit in pyproject.toml is not enforced and some lines exceed it.
meta-cla
Bot
added
the
CLA Signed
Deicyde
marked this pull request as draft
October 6, 2026 00:13
Deicyde
marked this pull request as ready for review
October 6, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTRIBUTING.mdwas the unedited template: a "..." placeholder for the development process, 2-space and 80-column rules, and a blank project name. It now gives the make targets CI runs, what the Lean and Windows CI jobs cover and which local tests skip without Lean, the ruff setup (default rules, which leave the 120-character limit inpyproject.tomlunenforced), and the project name.executionbranch's scheduler already usesClaimBoardand fails closed. The commands section says thePATHform assumes the Python package is installed, and that a consumer project lacks the package, not the plugin.Docs only: no code, manifest, test, or README changes. The README rewrite landed in #133.
Overlap
git merge-treeagainst every open PR head finds conflicts beyond the ones each PR already has withmainonly here:main.Validation
At e565b24 (two commits on
maine12382d):uv run pytest -q tests/test_skill_examples.py tests/test_markdown.py, 71 passed, andruff checkis clean.tests/test_skill_examples.pyis the only test that reads a changed file (the CLI reference); no test readsCONTRIBUTING.md.