Repository navigation
Reject nonlocal dashboard requests - #125
Merged
Merged
Conversation
Deicyde
marked this pull request as ready for review
October 5, 2026 21:42
Contributor
Author
|
Exact-head review is complete at |
Contributor
Author
|
The refreshed exact head |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binding to
127.0.0.1does not prevent DNS rebinding: before this change, a request withHost: attacker.examplereceived the private static site and live claim JSON with HTTP 200. The request-level authority check closes that boundary while preserving direct127.0.0.1andlocalhostuse.The HEAD guard matters because
SimpleHTTPRequestHandlerimplements it separately from GET; guarding onlydo_GETleft static metadata available to a nonlocal authority.Validation
At exact head
59e52996:make lint: passmake check-example: pass#137 has landed the former README baseline fix.
Fixes F29 from #92's adversarial review.