Skip to content

Remove code that nothing calls or reads - #114

Merged
Deicyde merged 1 commit into
facebookresearch:mainfrom
zibo-yang:cleanup/issue-113-dead-code
Oct 5, 2026
Merged

Deicyde merged 1 commit into
facebookresearch:mainfrom
zibo-yang:cleanup/issue-113-dead-code

Conversation

@zibo-yang

Copy link
Copy Markdown
Collaborator

Fixes #113.

What changes

Deletions only (58 lines, nothing added):

  • autoform_cli/render.py: _inject_after_title, _status_phrase, _markdown_table_cell and _shift_headings. The first and last were near-copies of the live _inject_after_lead and _demote_headings.
  • autoform_cli/claims.py: ClaimBoard.gc, an alias for cleanup().
  • servers/repl/core.py: the LeanReplConfig.mem_interval_check field.
  • servers/repl/pool.py: the constant DEFAULT_PORT.
  • render.py tidying: an empty f"" fragment in the progress overview and nine surplus blank lines. Two of those blank lines (before _next_target and before STRUCTURE_PAGE) are not listed in Remove dead code in render.py, claims.py and the REPL server #113; they were the same kind of leftover.

ClaimBoard.holds, ClaimBoard.heartbeat and Heartbeat are untouched, as the issue asks.

How it was checked

  • None of the seven symbols is referenced anywhere in the tree after the change, or on the execution branch. Every LeanReplConfig(...) construction uses keyword arguments and none passes mem_interval_check.
  • vulture autoform_cli servers reported exactly these seven before the change and none of them after.
  • make lint passes and make test gives 1026 passed, 34 skipped.
  • Rendering the example blueprint from clean checkouts of the base and of the original removal gives the same 24 files apart from the embedded commit SHA; audit and check output are identical. This comparison was not repeated after the two extra blank lines were removed.
  • make check-example and the strict MkDocs build were not run.

Notes for reviewers

🤖 Generated with Claude Code

Four render helpers, the ClaimBoard.gc alias, the REPL config field
mem_interval_check and the pool constant DEFAULT_PORT have no caller or
reader on main or on the execution branch. Two of the render helpers
were near-copies of live functions (_inject_after_lead and
_demote_headings).

Also drop an empty f"" fragment in the progress overview and nine
surplus blank lines in render.py.

The rendered site for the example blueprint is identical before and
after apart from the embedded commit SHA, and the audit output is
byte-identical.

Fixes facebookresearch#113

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 5, 2026
@Deicyde
Deicyde merged commit c994d83 into facebookresearch:main Oct 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead code in render.py, claims.py and the REPL server

2 participants