Repository navigation
Remove code that nothing calls or reads - #114
Merged
Deicyde merged 1 commit intoOct 5, 2026
Merged
Conversation
Four render helpers, the ClaimBoard.gc alias, the REPL config field mem_interval_check and the pool constant DEFAULT_PORT have no caller or reader on main or on the execution branch. Two of the render helpers were near-copies of live functions (_inject_after_lead and _demote_headings). Also drop an empty f"" fragment in the progress overview and nine surplus blank lines in render.py. The rendered site for the example blueprint is identical before and after apart from the embedded commit SHA, and the audit output is byte-identical. Fixes facebookresearch#113 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
What changes
Deletions only (58 lines, nothing added):
autoform_cli/render.py:_inject_after_title,_status_phrase,_markdown_table_celland_shift_headings. The first and last were near-copies of the live_inject_after_leadand_demote_headings.autoform_cli/claims.py:ClaimBoard.gc, an alias forcleanup().servers/repl/core.py: theLeanReplConfig.mem_interval_checkfield.servers/repl/pool.py: the constantDEFAULT_PORT.render.pytidying: an emptyf""fragment in the progress overview and nine surplus blank lines. Two of those blank lines (before_next_targetand beforeSTRUCTURE_PAGE) are not listed in Remove dead code in render.py, claims.py and the REPL server #113; they were the same kind of leftover.ClaimBoard.holds,ClaimBoard.heartbeatandHeartbeatare untouched, as the issue asks.How it was checked
executionbranch. EveryLeanReplConfig(...)construction uses keyword arguments and none passesmem_interval_check.vulture autoform_cli serversreported exactly these seven before the change and none of them after.make lintpasses andmake testgives 1026 passed, 34 skipped.auditandcheckoutput are identical. This comparison was not repeated after the two extra blank lines were removed.make check-exampleand the strict MkDocs build were not run.Notes for reviewers
mem_interval_checkandDEFAULT_PORT, so whichever of the two lands second will have a trivial conflict inservers/repl.vivc/devstill calls the four render helpers in its own olderrender.py. It is not an open pull request, but it would need them ported if it is ever rebased.autoform_worker/cli.pydoes not exist onexecution. It does exist there, but it callscleanup()and notgc, so the conclusion holds.🤖 Generated with Claude Code