Fix leading-zero normalizer skipping negative fractional values#1749
Open
durvesh1992 wants to merge 1 commit into
Open
Fix leading-zero normalizer skipping negative fractional values#1749durvesh1992 wants to merge 1 commit into
durvesh1992 wants to merge 1 commit into
Conversation
normalizeLeadingZero stripped the leading zero from positive fractions (0.5px -> .5px) for smaller output, but the guard `value < 1 && value >= 0` excluded negatives, so -0.5px was left untouched — inconsistent output for an equivalent value. Use Math.abs(value) < 1 so negative fractions are shortened too (-0.5px -> -.5px); 0 and |value| >= 1 are unchanged. Adds a regression test (fails before / passes after).
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The leading-zero normalizer shortens fractional CSS values for smaller output (
0.5px→.5px). But its guard excludes negative numbers:So
-0.5pxis emitted as-is while0.5pxbecomes.5px— inconsistent output for equivalent magnitudes. The transform already produces the correct shortened string for negatives ((-0.5).toString().replace('0.', '.')→-.5); only the value gate blocked it.Fix
Use
Math.abs(value) < 1so negative fractions are normalized too (-0.5px→-.5px).0/-0and|value| >= 1are unchanged.Test plan
Added a regression test (
marginTop: '-0.5px'→margin-top:-.5px) that fails before and passes after. Full babel-plugin suite: 960 passed, no snapshot regressions.