[docs] Replace playground Loading text with shimmer skeleton#1733
Open
ahmedsadid wants to merge 1 commit into
Open
[docs] Replace playground Loading text with shimmer skeleton#1733ahmedsadid wants to merge 1 commit into
ahmedsadid wants to merge 1 commit into
Conversation
|
@ahmedsadid is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
The playground showed a plain "Loading…" text while the editor booted up. This replaces it with a shimmer skeleton that mirrors the playgrounds editor/preview layout, so the loading state previews the eventual UI instead of a bare text label.
PlaygroundPlaceholderinDynamicPlayground.tsxinto skeleton editor panels (tab pills + code-line placeholders) and a preview panel, with an animated shimmer sweep (stylex.keyframes).role="status"/aria-label="Loading playground"for accessibility.Linked PR/Issues
Part of #1550
Additional Context
tsc, Prettier, ESLint, andwaku buildall pass. The placeholder is rendered server-side viaClientOnlys fallback, so it appears immediately on load.Pre-flight checklist