Run GitHub actions through latest Node.js LTS by default (currently v24)#2063
Open
robhogan wants to merge 1 commit into
Open
Run GitHub actions through latest Node.js LTS by default (currently v24)#2063robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
Summary: As part of migrating npm publishing to [Trusted Publish (OIDC)](https://docs.npmjs.com/trusted-publishers/), we'll need to use `npm` CLI at minimum 11.5.1, which is bundled with Node v24. This bumps the `setup-node` action for both publishing branches to the alias `lts/*` from the fixed `22.14.0`. Version ranges should be preferred over fixed versions to allow security fixes to be picked up in any case - this goes further than strictly necessary by moving to the dynamic `lts/*` alias (latest LTS). IMO that feels like a sensible, low-maintenance default. Differential Revision: D109435888
meta-cla
Bot
added
the
CLA Signed
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109435888. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As part of migrating npm publishing to Trusted Publish (OIDC), we'll need to use
npmCLI at minimum 11.5.1, which is bundled with Node v24.This bumps the
setup-nodeaction for both publishing branches to the aliaslts/*from the fixed22.14.0. Version ranges should be preferred over fixed versions to allow security fixes to be picked up in any case - this goes further than strictly necessary by moving to the dynamiclts/*alias (latest LTS). IMO that feels like a sensible, low-maintenance default.Differential Revision: D109435888