Skip to content

Add CLI option illustrations#3239

Draft
Meakk wants to merge 9 commits into
f3d-app:masterfrom
Meakk:option-illustration
Draft

Add CLI option illustrations#3239
Meakk wants to merge 9 commits into
f3d-app:masterfrom
Meakk:option-illustration

Conversation

@Meakk

@Meakk Meakk commented Jun 15, 2026

Copy link
Copy Markdown
Member

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this Jun 15, 2026
@Meakk Meakk added the ci:fast label Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will look strange with white background ? Unless there is a gray background ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to be able to tweak the background on the website to improve integration without having to regenerate baselines

@Meakk Meakk force-pushed the option-illustration branch from 2a3e514 to de3ab6b Compare June 16, 2026 06:56
@github-actions

Copy link
Copy Markdown

Style Checks CI failed:

diff --git a/vtkext/private/module/vtkF3DRenderer.cxx b/vtkext/private/module/vtkF3DRenderer.cxx
index 150e44c..e5f2fad 100644
--- a/vtkext/private/module/vtkF3DRenderer.cxx
+++ b/vtkext/private/module/vtkF3DRenderer.cxx
@@ -3725,5 +3725,6 @@ vtkMatrix4x4* vtkF3DRenderer::GetGridMatrix() const
 //----------------------------------------------------------------------------
 double vtkF3DRenderer::GetScreenSpaceScaling() const
 {
-  return this->AntiAliasingModeEnabled == vtkF3DRenderer::AntiAliasingMode::SSAA ? std::sqrt(5.0) : 1.0;
+  return this->AntiAliasingModeEnabled == vtkF3DRenderer::AntiAliasingMode::SSAA ? std::sqrt(5.0)
+                                                                                 : 1.0;
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants