Add support for USD Points primitive (#3210)#3231
Open
kaili-yang wants to merge 16 commits into
Open
Conversation
Import UsdGeomPoints as point-cloud polydata with vertex colors and skinning, and add module and application tests using skeleton_skin_basic.usda.
Author
|
\ci fast |
Meakk
requested changes
Jun 11, 2026
Meakk
reviewed
Jun 11, 2026
Use GetDisplayColorPrimvar with float RGB vertex colors, enable direct scalar coloring on the mapper, register godot-usd test data license, and fix the module test include and float color checks for CI.
kaili-yang
force-pushed
the
fix/usd-points-primitive-3210
branch
from
76d6269 to
f006fbd
Compare
Add usd_points_rgb.usda with well-separated RGB points so the render baseline is not occluded by mesh geometry from skeleton_skin_basic.usda.
Commit the CI-generated TestUSDPointsPrimitive baseline and verify per-vertex displayColor values in the module test.
Use double tuples when reading vtkDataArray values for VTK compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3231 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 213 212 -1
Lines 17652 17619 -33
=======================================
- Hits 17135 17103 -32
+ Misses 517 516 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Meakk
reviewed
Jun 12, 2026
Match the assimp plugin so vtkOpenGLShaderProperty is registered when TestF3DUSDImporterPoints updates skinned USD content in static builds.
Original F3D test data is covered by the default BSD-3-Clause notice.
Author
|
@Meakk Could you help re-run the failed CI job for me? It seems I don't have the permission to do that. |
Meakk
reviewed
Jun 15, 2026
Member
|
Member
|
\ci full |
Display colors use vtkFloatArray now; the header is no longer referenced.
Meakk
reviewed
Jun 15, 2026
Member
|
@mwestphal do you want to take a look too? |
Author
|
\ci full |
mwestphal
reviewed
Jun 16, 2026
mwestphal
reviewed
Jun 16, 2026
mwestphal
reviewed
Jun 16, 2026
mwestphal
reviewed
Jun 16, 2026
mwestphal
reviewed
Jun 16, 2026
Read displayOpacity alongside displayColor and store RGBA float scalars when opacity is authored, enabling translucent point rendering.
Meakk
reviewed
Jun 17, 2026
Use a single usd_points_rgb fixture with displayOpacity, keep DirectScalars Points-only, restore inline mesh skinning, and drop the OpenGL module link. Remove skeleton_skin_basic and the render baseline pending CI regeneration.
Member
|
Now points without opacity is not covered. |
Split usd_points_rgb.usda into two Points prims so opacity-only and color-only import paths are both exercised in TestF3DUSDImporterPoints.
Author
|
@Meakk Good idea, split into |
Refresh the render baseline after usd_points_rgb.usda was split into RGBAWithOpacity and RGBOnly so TestUSDPointsPrimitive matches CI output.
Meakk
approved these changes
Jun 19, 2026
Meakk
left a comment
Meakk
left a comment
Member
There was a problem hiding this comment.
LGTM!
@mwestphal do you want to take a look?
mwestphal
requested changes
Jun 20, 2026
kaili-yang
force-pushed
the
fix/usd-points-primitive-3210
branch
from
41f6fc9 to
b82decb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for the
USDPoints primitive (UsdGeomPoints) invtkF3DUSDImporter.Import
UsdGeomPoints→ poly-vertex polydatadisplayColor/displayOpacity→ float direct scalarsTests:
usd_points_rgb.usda（author-written，BSD-3-Clause default）No
OpenGL2, no mesh refactor, single fixtureIssue ticket number and link if any
Fixes #3210
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Cursor was used as a test assistant (Cursor / Composer) to help debug. I reviewed, validated, and adjusted the changes before submitting.
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.