Product Notes: A tag to give update about a product stock

[patrickreiffenstein]

Picture of the new tags for reference:

[krestenlaust]

Awesome feature!

[patrickreiffenstein]

@VinceUB put your thoughts about the tags in here

[VinceUB]

== English below ==
Hej Patrick,

Jeg har kigget på dine designs, og jeg har nogle forslag til ændringer, som du kan se i billedet nedenfor:

Ændringer:

• Teksten er hvid i stedet for sort, da jeg føler at det gør det nemmere at læse. (Hvis en af mærkerne har gul baggrund, skal teksten være sort.)
• Jeg har flyttet mærket til slutningen af linjen, hvilket føles mere naturligt i min mening.
• Jeg har eksperimenteret med at køre med gul baggrund frem for mærkerne, lidt à la spotvarer på supermarkedet. Jeg ved dog ikke om jeg er helt fan, den er lidt for støjende.

Jeg har ikke ændret det i selve koden, da jeg ikke kunne få stregsystemet op at køre :(

Med venlig hilsen,
Vincent

== Dansk ovenfor ==

Dear Patrick,

I have looked on your designs, and I have some suggestions to changes, that you can see in the picture below:

Changes:

• The text is white instead for black, because I feel that it does it easier to read. (If one of the labels has yellow background, should the text be black.)
• I have moved the label to the ending of the line, which feels more natural in my opinion.
• I have experimented with to go with yellow background instead of labels, a little à la spot products on the supermarket. I, however, don't know if I'm a complete fan, it is a little too noisy.

I have not changed it in the code itself, since I could not get the line system up to drive :(

With friendly greetings,
Vincent

[patrickreiffenstein]

== English below == Hej Patrick,

Jeg har kigget på dine designs, og jeg har nogle forslag til ændringer, som du kan se i billedet nedenfor:

Ændringer:

* Teksten er hvid i stedet for sort, da jeg føler at det gør det nemmere at læse. (Hvis en af mærkerne har gul baggrund, skal teksten være sort.)

* Jeg har flyttet mærket til slutningen af linjen, hvilket føles mere naturligt i min mening.

* Jeg har eksperimenteret med at køre med gul baggrund frem for mærkerne, lidt à la spotvarer på supermarkedet. Jeg ved dog ikke om jeg er helt fan, den er lidt for støjende.

Jeg har ikke ændret det i selve koden, da jeg ikke kunne få stregsystemet op at køre :(

Med venlig hilsen, Vincent

== Dansk ovenfor ==

Dear Patrick,

I have looked on your designs, and I have some suggestions to changes, that you can see in the picture below:

Changes:

* The text is white instead for black, because I feel that it does it easier to read. (If one of the labels has yellow background, should the text be black.)

* I have moved the label to the ending of the line, which feels more natural in my opinion.

* I have experimented with to go with yellow background instead of labels, a little à la spot products on the supermarket. I, however, don't know if I'm a complete fan, it is a little too noisy.

I have not changed it in the code itself, since I could not get the line system up to drive :(

With friendly greetings, Vincent

Hello my dear friend

Concerning the text colors. I thought about setting giving the possibility of setting the text color for the tags, but I felt it was too much, and I feel like I can read it best with black text.

I can see that the moving of the tag to the end is a possibility, but I feel like you mostly look at the left side of the table, so I feel like it is most attention grabbing there.

I agree on the row coloring being a bad idea.

Yours truly, Patrick

[krestenlaust]

== English below == Hej Patrick,
Jeg har kigget på dine designs, og jeg har nogle forslag til ændringer, som du kan se i billedet nedenfor:
Ændringer:

* Teksten er hvid i stedet for sort, da jeg føler at det gør det nemmere at læse. (Hvis en af mærkerne har gul baggrund, skal teksten være sort.)

* Jeg har flyttet mærket til slutningen af linjen, hvilket føles mere naturligt i min mening.

* Jeg har eksperimenteret med at køre med gul baggrund frem for mærkerne, lidt à la spotvarer på supermarkedet. Jeg ved dog ikke om jeg er helt fan, den er lidt for støjende.

Jeg har ikke ændret det i selve koden, da jeg ikke kunne få stregsystemet op at køre :(
Med venlig hilsen, Vincent
== Dansk ovenfor ==
Dear Patrick,
I have looked on your designs, and I have some suggestions to changes, that you can see in the picture below:
Changes:

* The text is white instead for black, because I feel that it does it easier to read. (If one of the labels has yellow background, should the text be black.)

* I have moved the label to the ending of the line, which feels more natural in my opinion.

* I have experimented with to go with yellow background instead of labels, a little à la spot products on the supermarket. I, however, don't know if I'm a complete fan, it is a little too noisy.

I have not changed it in the code itself, since I could not get the line system up to drive :(
With friendly greetings, Vincent

Hello my dear friend

Concerning the text colors. I thought about setting giving the possibility of setting the text color for the tags, but I felt it was too much, and I feel like I can read it best with black text.

I can see that the moving of the tag to the end is a possibility, but I feel like you mostly look at the left side of the table, so I feel like it is most attention grabbing there.

I agree on the row coloring being a bad idea.

Yours truly, Patrick

Dear @VinceUB and @patrickreiffenstein

I hope this comment, on a GitHub thread, finds you well.

What do you say to this comprimisation? Patrick can implement the "yellow rabatskilt"-feature using javascript using note tags, and he can implement a text and background color, then it's up to the staffmember to decide what to do

[patrickreiffenstein]

I have now added the possibility of changing the color of the text for @VinceUB. I will not add the "yellow rabatskilt"-feature, Vincent can make some javascript for the textfield if he really wants to use it for something as Kresten said.

[krestenlaust]

Great work! The feature turned out more simple (code wise) than I had expected, so I'll retire the review requests.

You may merge when you feel like it 👍

[atjn]

Tror I glemte at lave et quickbuy før I mergede det her:

[atjn]

Jeg har fundet et fiks: #554