Skip to content

Sync poker with problem specifications - #561

Merged
BNAndras merged 2 commits into
exercism:mainfrom
ManasDasri:sync-poker
Aug 28, 2026
Merged

Sync poker with problem specifications#561
BNAndras merged 2 commits into
exercism:mainfrom
ManasDasri:sync-poker

Conversation

@ManasDasri

@ManasDasri ManasDasri commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Sync the Poker exercise with the latest canonical test data from problem-specifications.

Changes

  • Added 7 missing canonical test cases to PokerTests.vb
  • Updated .meta/tests.toml with the corresponding canonical test entries
  • Applied the canonical reimplements relationships, excluding replaced cases
  • Updated the affected canonical test description

No changes to Example.vb were required.

Verification

  • ./bin/configlet sync -e poker --tests
  • pwsh ./bin/test.ps1 poker
  • Result: 37/37 tests passing

Closes #472

@github-actions

Copy link
Copy Markdown
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions Bot closed this Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions

Copy link
Copy Markdown
Contributor

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@github-actions

Copy link
Copy Markdown
Contributor

This is an unmaintained repository.

Cross-track maintainers - feel free to merge.

@BNAndras BNAndras reopened this Aug 26, 2026
@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:action/sync Sync content with its latest version x:rep/large Large amount of reputation labels Aug 27, 2026
Comment thread exercises/practice/poker/PokerTests.vb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the reimplemented test

Comment thread exercises/practice/poker/PokerTests.vb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the reimplemented test

Comment thread exercises/practice/poker/PokerTests.vb Outdated
End Sub

<Fact(Skip:="Remove this Skip property to run this test")>
Public Sub Even_though_an_ace_is_usually_high_a_5_high_straight_flush_is_the_lowest_scoring_straight_flush()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should be the last in the suite after Both_hands_have_a_straight_flush_tie_goes_to_highest_ranked_card

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the order

@ManasDasri

Copy link
Copy Markdown
Contributor Author

Addressed all requested changes:

  • Removed With_multiple_decks_two_players_can_have_same_three_of_a_kind_ties_go_to_highest_remaining_cards, which is reimplemented by the canonical case.
  • Removed Both_hands_have_a_flush_tie_goes_to_high_card_down_to_the_last_one_if_necessary, which is also reimplemented canonically.
  • Moved Even_though_an_ace_is_usually_high_a_5_high_straight_flush_is_the_lowest_scoring_straight_flush to the end of the test suite, after the straight-flush tie case.

Verified with ./bin/test.ps1 poker: 34/34 tests passing.
./bin/configlet sync -e poker --tests also reports the exercise as up to date.

@BNAndras
BNAndras merged commit b5e3bed into exercism:main Aug 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync poker with problem specifications

2 participants