Skip to content

Add game-of-life exercice#780

Merged
glennj merged 6 commits into
exercism:mainfrom
resu-xuniL:game-of-life
Jun 16, 2026
Merged

Add game-of-life exercice#780
glennj merged 6 commits into
exercism:mainfrom
resu-xuniL:game-of-life

Conversation

@resu-xuniL

@resu-xuniL resu-xuniL commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Add baffling-birthdays exercice to track.
I change difficulty from 1 to 6.

Hope everything is correct.


Reviewer Resources:

Track Policies

Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/game_of_life.bats Outdated
Comment thread exercises/practice/game-of-life/game_of_life.bats Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/game_of_life.bats
Comment thread exercises/practice/game-of-life/game_of_life.bats Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
* Co-authored-by: IsaacG
* Co-authored-by: glennj

@glennj glennj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in retrospect, wrangling 2-D arrays in bash is more difficult than "4".

Approved though.

@resu-xuniL

Copy link
Copy Markdown
Contributor Author

Shall I change the difficulty ranking?

@resu-xuniL

Copy link
Copy Markdown
Contributor Author

Shall I change the difficulty ranking?

Is it a 5? a 6? (what is the max?)

@glennj

glennj commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Is it a 5? a 6? (what is the max?)

Documented at https://exercism.org/docs/building/tracks/config-json#h-practice-exercises

@resu-xuniL

resu-xuniL commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Is it a 5? a 6? (what is the max?)

Documented at https://exercism.org/docs/building/tracks/config-json#h-practice-exercises

I would go for 6 (i see Tournament exercice is 5). Is this OK ?

@IsaacG

IsaacG commented Jun 16, 2026

Copy link
Copy Markdown
Member

You may want to update the PR description ;)

Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/.meta/example.sh
Comment thread config.json Outdated
@IsaacG

IsaacG commented Jun 16, 2026

Copy link
Copy Markdown
Member

in retrospect, wrangling 2-D arrays in bash is more difficult than "4".

Note, a 2D array isn't needed. You can use an array of strings and double index.

game=( "$@" )
row=${game[y])
cell="${row:x:1}"

Comment thread exercises/practice/game-of-life/.meta/example.sh Outdated
Comment thread exercises/practice/game-of-life/game_of_life.bats Outdated

@IsaacG IsaacG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The first test case should use a format consistent with the other tests. Otherwise I'm happy to see this merged. Anything else for you, Glenn?

…sm#784)

update comments in bats-extra.bash files
author: glennj
Comment thread exercises/practice/game-of-life/game_of_life.bats Outdated
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
@glennj glennj merged commit 17c58b9 into exercism:main Jun 16, 2026
3 checks passed
@glennj

glennj commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Thanks for remaining persistent and getting this PR finished!

@resu-xuniL

Copy link
Copy Markdown
Contributor Author

Thanks to you both for your mentoring!

@resu-xuniL resu-xuniL deleted the game-of-life branch June 16, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants