Skip to content

Add focused performance benchmarks - #2

Merged
euforic merged 1 commit into
mainfrom
euforic/add-performance-benchmarks
Aug 12, 2026
Merged

Add focused performance benchmarks#2
euforic merged 1 commit into
mainfrom
euforic/add-performance-benchmarks

Conversation

@euforic

@euforic euforic commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

  • benchmark real loopback HTTP/1.1 and HTTP/2 proxy requests
  • benchmark concurrent route resolution with periodic atomic replacement
  • benchmark durable registry commits at 1, 100, and 1,024 routes
  • benchmark cached, uncached, and bounded-eviction certificate issuance
  • document reproducible benchmem runs and measurement caveats

No production behavior changed; the baseline did not demonstrate a clear defect.

Validation

  • go fmt ./...
  • go vet ./...
  • go test ./...
  • go test -race ./...
  • five 2-second benchmem samples on Apple M2 Ultra

Copilot AI lite review requested due to automatic review settings August 12, 2026 03:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@euforic
euforic merged commit b3f74e2 into main Aug 12, 2026
5 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed49197262

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

b.ResetTimer()
b.RunParallel(func(pb *testing.PB) {
for pb.Next() {
operation := operations.Add(1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the shared counter from the resolve hot path

Under parallel benchmark execution, every measured operation first performs an update to the same atomic cache line, so all resolver goroutines contend on operations before reaching Table.Resolve. At higher CPU counts this contention can dominate the reported latency and make changes to the route table appear neutral or noisy; drive replacements from a separate mutator or use per-worker scheduling so ordinary resolve iterations do not share a global counter.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants