Add focused performance benchmarks - #2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed49197262
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| b.ResetTimer() | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| operation := operations.Add(1) |
There was a problem hiding this comment.
Remove the shared counter from the resolve hot path
Under parallel benchmark execution, every measured operation first performs an update to the same atomic cache line, so all resolver goroutines contend on operations before reaching Table.Resolve. At higher CPU counts this contention can dominate the reported latency and make changes to the route table appear neutral or noisy; drive replacements from a separate mutator or use per-worker scheduling so ordinary resolve iterations do not share a global counter.
Useful? React with 👍 / 👎.
Summary
No production behavior changed; the baseline did not demonstrate a clear defect.
Validation