robustness: implement cluster client endpoint switching#21471
robustness: implement cluster client endpoint switching#21471henrybear327 wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 27 files with indirect coverage changes @@ Coverage Diff @@
## main #21471 +/- ##
==========================================
- Coverage 68.47% 68.43% -0.04%
==========================================
Files 428 428
Lines 35291 35291
==========================================
- Hits 24165 24152 -13
- Misses 9730 9738 +8
- Partials 1396 1401 +5 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/retest |
9894653 to
4154465
Compare
4154465 to
4f6863f
Compare
995b1f2 to
18929bb
Compare
18929bb to
5793558
Compare
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
5793558 to
62787b8
Compare
| defer wg.Done() | ||
| defer c.Close() | ||
|
|
||
| if profile.Watch != nil && profile.Watch.EndpointSwitchPeriod != nil { |
There was a problem hiding this comment.
Not sure if this is a better idea than treating 0 as "don't switch".
|
/retest |
|
Can you describe the solution, how it works, what purpose it serve, what are alternatives? |
Introduce optional cluster client endpoint switching.
This would allow us to test out the client reconnection behaviors, such as the resumable guarantee for watches.
Used in #21472