Skip to content

robustness: implement cluster client endpoint switching#21471

Draft
henrybear327 wants to merge 1 commit intoetcd-io:mainfrom
henrybear327:robustness/cluster-client-endpoint-switching
Draft

robustness: implement cluster client endpoint switching#21471
henrybear327 wants to merge 1 commit intoetcd-io:mainfrom
henrybear327:robustness/cluster-client-endpoint-switching

Conversation

@henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Mar 11, 2026

Introduce optional cluster client endpoint switching.

This would allow us to test out the client reconnection behaviors, such as the resumable guarantee for watches.

Used in #21472

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.43%. Comparing base (50f4ea2) to head (62787b8).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21471      +/-   ##
==========================================
- Coverage   68.47%   68.43%   -0.04%     
==========================================
  Files         428      428              
  Lines       35291    35291              
==========================================
- Hits        24165    24152      -13     
- Misses       9730     9738       +8     
- Partials     1396     1401       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f4ea2...62787b8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrybear327
Copy link
Contributor Author

/retest

@henrybear327 henrybear327 marked this pull request as draft March 12, 2026 15:13
@henrybear327 henrybear327 force-pushed the robustness/cluster-client-endpoint-switching branch from 9894653 to 4154465 Compare March 15, 2026 20:48
@henrybear327 henrybear327 force-pushed the robustness/cluster-client-endpoint-switching branch from 4154465 to 4f6863f Compare March 16, 2026 21:51
@henrybear327 henrybear327 force-pushed the robustness/cluster-client-endpoint-switching branch 7 times, most recently from 995b1f2 to 18929bb Compare March 17, 2026 14:42
@henrybear327 henrybear327 force-pushed the robustness/cluster-client-endpoint-switching branch from 18929bb to 5793558 Compare March 17, 2026 14:53
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
@henrybear327 henrybear327 force-pushed the robustness/cluster-client-endpoint-switching branch from 5793558 to 62787b8 Compare March 17, 2026 17:29
@henrybear327 henrybear327 marked this pull request as ready for review March 17, 2026 17:31
defer wg.Done()
defer c.Close()

if profile.Watch != nil && profile.Watch.EndpointSwitchPeriod != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is a better idea than treating 0 as "don't switch".

@henrybear327
Copy link
Contributor Author

/retest

@serathius
Copy link
Member

Can you describe the solution, how it works, what purpose it serve, what are alternatives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants