Skip to content

devcontainer: bump Go image to 1.26#21407

Closed
shuan1026 wants to merge 1 commit intoetcd-io:mainfrom
shuan1026:devcontainer-bump-go-1.26
Closed

devcontainer: bump Go image to 1.26#21407
shuan1026 wants to merge 1 commit intoetcd-io:mainfrom
shuan1026:devcontainer-bump-go-1.26

Conversation

@shuan1026
Copy link
Copy Markdown
Contributor

Ref #21364

Align the devcontainer with the main branch Go 1.26.

Note: Use mcr.microsoft.com/devcontainers/go:1.26-bookworm. The stable 1.26-bookworm tag has not been published on MCR yet; this PR is prepared in advance and will be ready to merge once the tag becomes available.


MCR devcontainers/go 1.26-related tags (queried on 2026-03-03)

Source: https://mcr.microsoft.com/v2/devcontainers/go/tags/list

Tag Status
dev-1.26 Available
dev-1.26-bookworm Available
dev-1.26-trixie Available
1.26-bookworm Not yet published

Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shuan1026
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @shuan1026. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc mentioned this pull request Mar 4, 2026
18 tasks
@christophsj
Copy link
Copy Markdown

Hi @shuan1026,

I am new here, looking for ways to contribute, and noticed that setting up the dev environment using the dev container isn't working due to the Go image.

In the meantime, the devcontainer image has been published, so I think this PR could be merged.

https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/go/tag/1.26-bookworm

@shuan1026 shuan1026 marked this pull request as ready for review March 27, 2026 11:50
@shuan1026
Copy link
Copy Markdown
Contributor Author

Hi @shuan1026,

I am new here, looking for ways to contribute, and noticed that setting up the dev environment using the dev container isn't working due to the Go image.

In the meantime, the devcontainer image has been published, so I think this PR could be merged.

https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/go/tag/1.26-bookworm

Thanks for confirming! Moving this out of draft now.

@henrybear327
Copy link
Copy Markdown
Contributor

Closing this PR in favor of #21539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants