fix SQL parameter passing in setProps to save complex modifications#1786
Open
rock1565 wants to merge 2 commits into
Open
fix SQL parameter passing in setProps to save complex modifications#1786rock1565 wants to merge 2 commits into
rock1565 wants to merge 2 commits into
Conversation
|
Nice catch on the param binding. One small thing though. This also strips the backticks off the identifiers ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
改进了sql语句 使其更难出现问题
Motivation
使用复杂改装时常常无法保存我的改装 一路排查到这 为避免后续的人们遇到问题 所以我决定贡献
Implementation Details
MySQL.update.await 期望第二个参数是一个数组
但 setProps() 方法将它们作为单独的参数传递,导致 UPDATE 查询静默失败 在第170行给参数加上大括号就能解决
Usage Example
PR Checklist