You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added options to set the ToS/DSCP of the control connection.
This helps prevent the control connection from dropping when testing low-capacity networks.
It was suggested in the discussion thread that this option should be added to the existing --tos option with a slash separator.
I decided against that because the control ToS option is available to both the client and server.
I checked, but for some reason with each test I capture two packets with TOS=0.
Without specifying the TOS, we get 14 packets with TOS=0. That is, two packets remain unmarked with the custom TOS we need.
@jake-rus The initial 2 packets are unmarked as they are sent when the client connects within the netdial function.
To mark those packets, I could replace netdial to set the TOS before the socket connects, but I'm not sure what the maintainers would prefer.
Since they are sent before the main traffic is generated, the unmarked packets don't affect my tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from the discussion in #1982.
Added options to set the ToS/DSCP of the control connection.
This helps prevent the control connection from dropping when testing low-capacity networks.
It was suggested in the discussion thread that this option should be added to the existing
--tosoption with a slash separator.I decided against that because the control ToS option is available to both the client and server.