Repository navigation
Replace ActiveSupport::Configurable with class_attribute - #199
Merged
junk0612 merged 1 commit intoApr 14, 2026
Merged
Conversation
issei-m
force-pushed
the
replace-as-configurable-with-class-attribute
branch
from
April 6, 2026 11:02
13222c6 to
2d15785
Compare
Member
|
Since CI is now working on GitHub Actions in #202, could you rebase this branch? |
issei-m
force-pushed
the
replace-as-configurable-with-class-attribute
branch
2 times, most recently
from
April 9, 2026 16:20
df6bd16 to
0b6fbf7
Compare
Contributor
Author
|
@junk0612 Thanks for your hard work! Also finished rebasing and passing all CI tasks. |
junk0612
reviewed
Apr 10, 2026
Member
|
@issei-m Can you squash your commits into one? |
ActiveSupport::Configurable is deprecated in Rails 8.1 and will be removed in Rails 8.2. Migrate to class_attribute as recommended by the deprecation notice. Update callablize to use send(name) instead of config[name] since the OrderedOptions object is no longer present. Co-authored-by: Junichi Kobayashi <nnujabok@gmail.com>
issei-m
force-pushed
the
replace-as-configurable-with-class-attribute
branch
from
April 14, 2026 04:07
91e1c41 to
c9f5995
Compare
Contributor
Author
|
@koic Done. |
junk0612
approved these changes
Apr 14, 2026
junk0612
left a comment
junk0612
left a comment
Member
There was a problem hiding this comment.
CI is failing, but this looks like it’s just due to a flaky test.
Member
|
Thank you for your works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveSupport::Configurable is deprecated in Rails 8.1 and will be removed in Rails 8.2. Migrate to class_attribute as recommended by the deprecation notice. Update callablize to use send(name) instead of config[name] since the OrderedOptions object is no longer present.