Fix Inno Setup paths#151
Open
tjsr wants to merge 77 commits into
Open
Conversation
Author
|
Hi @esitarski - what do you need to approve and get this one merged in? Is the issue that the PR is raised against |
tjsr
force-pushed
the
fix/inno-setup-paths
branch
2 times, most recently
from
February 25, 2025 02:55
ba59102 to
3406583
Compare
Ensure InnoSetup is available before starting build.
tjsr
force-pushed
the
fix/inno-setup-paths
branch
from
February 26, 2025 01:42
3406583 to
80f1099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#147
Rework InnoSetup path checks. Ensure InnoSetup is available before starting build.
Removes hard-coded locations to look for InnoSetup, and now checks the registry path (if found), then 'Program Files' and 'Program Files (x86)' on all available drive letters, and then the User AppLocal and Local\Programs directories, and iterates through that list until the executable is found.
The check has also been moved to the first step of the build process when -Everything is specified, and fails fast if InnoSetup is not installed.