Repository navigation
show email sending errors from NS SENDPASS - #2473
Merged
slingamn merged 1 commit intoNov 1, 2026
Merged
Conversation
Member
|
Fantastic, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NS SENDPASS only replied "An error occurred" when the email could not be sent. This wraps the send error in
registrationCallbackError, the same way REGISTER and SETEMAIL do, so the user sees the SMTP error when direct sending is enabled and "Could not dispatch registration e-mail" otherwise.The failed attempt still counts toward the reset cooldown, so a retry gets "Try again later" (the second line in the issue log). I left that alone, happy to change it if you want.
Fixes #2430