[ext-fintraffic] Persist and expose vehicle entrance accessModes - #431
Open
teppope wants to merge 25 commits into
Open
[ext-fintraffic] Persist and expose vehicle entrance accessModes#431teppope wants to merge 25 commits into
teppope wants to merge 25 commits into
Conversation
Implements the extension hook infrastructure from feat/parking-extension-hooks to persist and expose paymentMethods on the Fintraffic Parking entity: - FintrafficParking: @entity subclass with @ElementCollection paymentMethods - FintrafficParkingEntityFactory: produces FintrafficParking instances - FintrafficMergingParkingImporter: copies paymentMethods into the persisted entity - FintrafficParkingGraphQLTypeContributor: adds paymentMethods to the GraphQL schema - FintrafficParkingUpdater: populates and preserves paymentMethods on GraphQL mutations - FintrafficParkingMapperContributor: bridges paymentMethods between NeTEx and Tiamat enums - V3__FintrafficParkingExtensions: Flyway migration adding dtype column and payment methods table - Full test coverage: unit + integration tests for all components Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Factory Orika cannot auto-map paymentMethods because the NeTEx and Tiamat enum types differ. The FintrafficParkingMapperContributor already handles the conversion explicitly, so including paymentMethods in the Orika classmap was redundant and confusing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xtProvider static field Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… core tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…t completeness - Add UNIQUE (parking_id, day_type_ref) constraint to V7 migration - Importer deduplicates by dayTypeRef (warn + keep last) to prevent DB constraint violations - GraphQL updater rejects duplicate dayTypeRef with IllegalArgumentException - parseLocalTime validates input; handles 24:00->midnight; throws IllegalArgumentException on bad values - Timeband created on export when either startTime or endTime is non-null - Tests for deduplication in importer and error paths in GraphQL updater Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Guard against empty first token after split in parseLocalTime (e.g. input ':') - Add export test for endTime-only timeband (startTime null) - Error-path tests verify no parking is persisted on duplicate dayTypeRef or invalid time Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…cognized JPA entity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xt-fintraffic-info-links
…c-vehicle-entrances
…ntraffic-parking-lighting
…traffic-parking-opening-hours
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…traffic-parking-opening-hours
…t-fintraffic-vehicle-entrance-access-modes
teppope
changed the title
teppope
marked this pull request as ready for review
July 30, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParkingEntranceForVehicles.accessModes(AccessModeEnumerationlist, e.g.foot,bicycle) on the Fintraffic parking extension so pedestrian/bicycle port access mapped by the Liipi migration tool (seedigitraffic-tis-parking-netex-migrationPR Can't find stop places with no valid version from UI #12) round-trips through Tiamat's GraphQL API and NeTEx import/export.AccessModesis an XML list-typed field (single element containing space-separated tokens, e.g.<AccessModes>foot bicycle</AccessModes>), not a repeatable element, so it is stored as a singleVARCHAR(128)column (access_modes) onFintrafficParkingEntranceForVehiclesrather than a nested@ElementCollectiontable. A parsedList<String>convenience view (getAccessModesList()/setAccessModesList()) is provided for callers.accessModesfield (newaccessModeEnumtype) on both the vehicle entrance output and input types, wired throughFintrafficParkingUpdaterfor mutations.V8__FintrafficParkingVehicleEntranceAccessModesfor the new column.Depends on this stacked ext branch chain being merged first, in order: #422 (paymentMethods) → #424 (infoLinks) → #425 (vehicleEntrances) → #429 (lighting) → #430 (opening hours) → this branch. This branch is based on the tip of that stack (
feat/ext-fintraffic-parking-opening-hours) so the new migration could be assigned versionV8without colliding withV6/V7already claimed by branches ahead of it in the stack.Type of change
Unit tests
FintrafficParkingEntranceForVehiclesTestcovering theaccessModesraw-string ↔List<String>conversion helpers andequals()/hashCode().FintrafficParkingMapperContributorTest(NeTEx↔Tiamat mapping) andFintrafficMergingParkingImporterTest(new test verifying a change to onlyaccessModestriggers a new parking version) withaccessModescoverage.mutateParking_vehicleEntrances_accessModes_persistedAndReturnedInResponsetoFintrafficGraphQLParkingIntegrationTestverifying the full GraphQL mutate → persist → query round trip.mvn test -Dtest=FintrafficParkingEntranceForVehiclesTest,FintrafficParkingMapperContributorTest,FintrafficMergingParkingImporterTest,FintrafficGraphQLParkingIntegrationTest).