Conversation
teppope
marked this pull request as ready for review
July 30, 2026 06:09
teppope
marked this pull request as draft
July 30, 2026 06:39
teppope
marked this pull request as ready for review
July 30, 2026 06:44
…input types Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
teppope
force-pushed
the
feat/parking-cycle-storage-graphql
branch
from
September 3, 2026 11:55
816baa4 to
d0fbbd8
Compare
Collaborator
Author
|
Closing in favour of #465. This fix has been folded into #465 unchanged (cherry-picked as commit Consolidating was requested so that all parking changes land as a single PR. The trade-off is noted: this fix now merges with #465 rather than on its own — happy to re-extract it if you would prefer to merge it separately first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
placeEquipmentsto the Parking GraphQL output and input types, enabling cycle storage equipment (and other place equipment) to be read and written viamutateParking.The storage layer already supports this: the
parkingtable has aplace_equipments_idFK, andPlaceEquipmentMapperhandlesCycleStorageEquipmentbidirectionally. ThePlaceEquipmentsGraphQL type already includedcycleStorageEquipment. The only missing pieces were wiring the field into the parking-specific types and registering the data fetcher.Type of change
Issue
Cycle storage equipment was persisted on
Parkingentities via NeTEx import but was not accessible via the GraphQL API. This is needed for the Fintraffic Liipi P&R migration to expose cycle storage (mapped fromBICYCLE_FRAME_LOCKservice flags) through the editor.placeEquipmentsfield tocreateParkingObjectType(output)placeEquipmentsfield tocreateParkingInputObjectType(input)Parkingcase todataFetcherPlaceEquipmentsinStopPlaceRegisterGraphQLSchemaOUTPUT_TYPE_PARKINGPlaceEquipmentMapperhandling inParkingUpdater.populateParkingUnit tests
Added
testMutateParkingWithCycleStorageShouldPersistAndReturninGraphQLResourceParkingIntegrationTest: creates a parking viamutateParkingwithplaceEquipments.cycleStorageEquipmentand asserts the type and number of spaces are returned in the response.Documentation
N/A — fields are standard NeTEx, no additional documentation needed.