Remove unused re2j dependency - #524
Merged
Merged
Conversation
re2j is not referenced by the build and is already pulled in transitively (same version, 1.8) through protovalidate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Removes the unused direct com.google.re2j:re2j dependency while retaining transitive availability through Protovalidate.
Changes:
- Deletes the direct
re2jdependency declaration. - Leaves existing schema unpack configuration unchanged.
| File | Description |
|---|---|
pom.xml |
Removes the unused dependency declaration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
com.google.re2j:re2j(provided). Nothing in the build references it, and protovalidate already brings it in transitively at the same version (1.8).schema2proto-xsdprotois also flagged bydependency:analyze, but it stays: the unpack execution takes its version from the dependency list.Verified with
mvn installon main.🤖 Generated with Claude Code