More accurate opentelemetry spring boot starter condition - #465
Merged
Conversation
erlendnils1
approved these changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts GCP trace auto-configuration gating so the “fallback” correlation/trace ID integrations only activate when the Spring Boot OpenTelemetry starter auto-config is not present (rather than merely when the OpenTelemetry API is absent/present). This better aligns cloud-logging’s Spring Boot auto-config behavior with the intended dependency signal.
Changes:
- Updated servlet trace auto-configuration to condition on the absence of Spring Boot’s
OpenTelemetrySdkAutoConfiguration. - Updated gRPC trace auto-configuration to condition on the absence of Spring Boot’s
OpenTelemetrySdkAutoConfiguration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gcp/correlation-id-trace-spring-boot-gcp-web/src/main/java/no/entur/logging/cloud/gcp/trace/spring/web/GcpTraceAutoConfiguration.java | Tightens the conditional guard to detect the Spring Boot OpenTelemetry starter auto-config class rather than the generic OTel API class. |
| gcp/correlation-id-trace-spring-boot-gcp-grpc/src/main/java/no/entur/logging/cloud/gcp/trace/spring/grpc/GcpGrpcTraceAutoConfiguration.java | Mirrors the same conditional refinement for the gRPC interceptor auto-configuration path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a class actually in the starter, not just the opentelemetry api.