Fix match scrutinee not being dropped#165
Draft
tothambrus11 wants to merge 1 commit into
Draft
Conversation
A match materializes its scrutinee into an owned local, but the block wrapping it
is built with an empty cleanup list, so the local is never dropped. When an arm
binds the payload by reference the scrutinee stays live, so a resource-owning
scrutinee leaks. The clearest case is a for-loop, which lowers to
`match next(it) { Some(x) => …, None => break }`: the Option the iterator yields
each iteration is never dropped.
Adds the scrutinee local to the block's cleanup. The test fails without it (the
scrutinee's Probe drop never runs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
matchmaterializes its scrutinee into an owned local, but the block wrapping it is built with an empty cleanup list, so the local is never dropped.When an arm binds the payload by reference the scrutinee stays live, so a resource-owning scrutinee leaks. The clearest case is a
for-loop, which lowers tomatch next(it) { Some(x) => …, None => break }— theOptionthe iterator yields each iteration is never dropped.The fix just adds the scrutinee local to the block's cleanup. The added test fails without it: the scrutinee's
Probedrop never runs, so the recorded drop log is empty instead of7.