Added ssa lowering#125
Conversation
208cabb to
a32a740
Compare
2d5f388 to
375d16c
Compare
|
@MartTave thank you for the PR. I enabled the workflow, as you can see there are formatting issues. Also, I corrected the CI script in 48596bc to only attempt to deploy the book and the playground for the main branch. Please rebase on Is that PR ready to be merged or is it a work-in-progress PR? |
|
The file .vscode/launch.json has a single command specific for SSA but not named as such. Was it your intention to add it to this PR? |
|
Hello, I should have written a message here first. Apparently, when we open a PR to a fork, a PR gets opened automatically to the original repo too. This PR is meant to facilitate the code review with Dimi. But, I will take a look now at the formatting issue, so that we can tackle that as early as possible. For now, I think it is okay to close this PR. As we will do a final one once all the code on our side is done. Thanks again |
|
For me it is fine to keep the PR open, I just converted it to draft so that it doesn't get merged by mistake while it is in progress. |
|
For the formatting, just run |
|
Also, could you say something on #25, such as "I am working on it"? That will allow me to assign you to it, as according to github documentation posting a comment on an issue will make you appear on the possible assignee list. Thank you! |
|
Done ! |
6cd0e74 to
37b35ce
Compare
Refactored and fixed problems after rebase
7a28fa6 to
8ecd4bf
Compare
Added lowering for :
Added --print-ssa flag to repl
Added ssa emitting tests