Skip to content

Added ssa lowering#125

Draft
MartTave wants to merge 4 commits into
enlightware:mainfrom
kyouko-taiga:feature/control_flow
Draft

Added ssa lowering#125
MartTave wants to merge 4 commits into
enlightware:mainfrom
kyouko-taiga:feature/control_flow

Conversation

@MartTave

Copy link
Copy Markdown

Added lowering for :

  • Apply
  • StaticApply
  • GetDictionnary
  • Loop
  • Case
  • Block
  • Project
  • ExtractTag
  • Immediate

Added --print-ssa flag to repl
Added ssa emitting tests

@MartTave MartTave force-pushed the feature/control_flow branch from 208cabb to a32a740 Compare April 20, 2026 07:59
@CLAassistant

CLAassistant commented Apr 20, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@stephanemagnenat

Copy link
Copy Markdown
Member

@MartTave thank you for the PR. I enabled the workflow, as you can see there are formatting issues.

Also, I corrected the CI script in 48596bc to only attempt to deploy the book and the playground for the main branch. Please rebase on main to get this change.

Is that PR ready to be merged or is it a work-in-progress PR?

@stephanemagnenat

Copy link
Copy Markdown
Member

The file .vscode/launch.json has a single command specific for SSA but not named as such. Was it your intention to add it to this PR?

@MartTave

Copy link
Copy Markdown
Author

Hello,

I should have written a message here first.

Apparently, when we open a PR to a fork, a PR gets opened automatically to the original repo too.

This PR is meant to facilitate the code review with Dimi.

But, I will take a look now at the formatting issue, so that we can tackle that as early as possible. For now, I think it is okay to close this PR. As we will do a final one once all the code on our side is done.

Thanks again

@stephanemagnenat stephanemagnenat marked this pull request as draft April 21, 2026 08:26
@stephanemagnenat

Copy link
Copy Markdown
Member

For me it is fine to keep the PR open, I just converted it to draft so that it doesn't get merged by mistake while it is in progress.

@stephanemagnenat

Copy link
Copy Markdown
Member

For the formatting, just run cargo fmt ;-)

@stephanemagnenat

Copy link
Copy Markdown
Member

Also, could you say something on #25, such as "I am working on it"? That will allow me to assign you to it, as according to github documentation posting a comment on an issue will make you appear on the possible assignee list. Thank you!

@stephanemagnenat stephanemagnenat added the ssa Static Single-Assignment form low-lever intermediate representation. label Apr 21, 2026
@MartTave

Copy link
Copy Markdown
Author

Done !

@MartTave MartTave force-pushed the feature/control_flow branch from 6cd0e74 to 37b35ce Compare May 11, 2026 13:09
MartTave added 2 commits May 25, 2026 11:29
Refactored and fixed problems after rebase
@MartTave MartTave force-pushed the feature/control_flow branch from 7a28fa6 to 8ecd4bf Compare May 25, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ssa Static Single-Assignment form low-lever intermediate representation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants