added custom error handling utility#258
Open
TanmayTiwarii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This PR addresses an issue where the API endpoints returned
400 Bad Requestfor various operational failures (such as missing indexes or backup name conflicts).It introduces a centralized exception class,
ndd::ApiError, which encapsulates the appropriate HTTP status codes. The core backend logic (IndexManagerandBackupStore) has been updated to throw these exceptions rather than returning boolean pairs or generic runtime errors. The router (main.cpp) now catches these custom exceptions and relays the precise HTTP status code back to the client.Type of Change
Related Issue
Closes #249
Checklist