RUI-000: Translate dropdown search placeholder and Apply button - #289
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
mad-raccoon
approved these changes
Sep 17, 2026
mad-raccoon
approved these changes
Sep 17, 2026
mad-raccoon
left a comment
Collaborator
There was a problem hiding this comment.
we just need to release the RUI, and update the version on this repo
mad-raccoon
marked this pull request as ready for review
September 17, 2026 16:51
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
common.searchandcommon.applytheme i18n keys (en: "Search…" / "Apply", de: "Suchen…" / "Anwenden").submitLabel(Apply button) to every multi-select andsearchPlaceholderto every searchable select/multi-select — previously these always showed the English remarkable-ui defaults, with no translation key available.Depends on
searchPlaceholderprop). Draft until that ships: bump@embeddable.com/remarkable-uito the release containing it, then types will pass and this can be marked ready.Testing
types:check,eslint:check, and all 450 editor tests pass against the file-linked remarkable-ui build.🤖 Generated with Claude Code
Summary by CodeRabbit