Skip to content

RUI-000: Translate dropdown search placeholder and Apply button - #289

Merged
mad-raccoon merged 3 commits into
mainfrom
RUI-000_translate_search_apply
Sep 17, 2026
Merged

mad-raccoon merged 3 commits into
mainfrom
RUI-000_translate_search_apply

Conversation

@hjkmarshall

@hjkmarshall hjkmarshall commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds common.search and common.apply theme i18n keys (en: "Search…" / "Apply", de: "Suchen…" / "Anwenden").
  • Passes submitLabel (Apply button) to every multi-select and searchPlaceholder to every searchable select/multi-select — previously these always showed the English remarkable-ui defaults, with no translation key available.
  • Covers MultiSelectFieldPro, MeasureMultiSelectFieldPro, DimensionOrMeasureMultiSelectFieldPro, SingleSelectFieldPro, and all FilterBuilder variants.

Depends on

Testing

  • types:check, eslint:check, and all 450 editor tests pass against the file-linked remarkable-ui build.
  • Verified in the Embeddable builder with a German theme: search shows "Suchen…", apply button "Anwenden"; empty-string theme overrides render an empty placeholder.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Search placeholders in searchable dropdowns are now localized in English and German.
    • Multi-select controls now display localized Apply button text.
    • Updated filter builders and dimension/measure selectors for consistent translated labels.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1f9a2e0e-a091-4227-ad76-518e9074c531

📥 Commits

Reviewing files that changed from the base of the PR and between f17e2a8 and 4830b24.

📒 Files selected for processing (14)
  • .changeset/calm-search-applies.md
  • src/components/editors/DimensionOrMeasureMultiSelectFieldPro/index.tsx
  • src/components/editors/MeasureMultiSelectFieldPro/index.tsx
  • src/components/editors/MultiSelectFieldPro/index.tsx
  • src/components/editors/SingleSelectFieldPro/index.tsx
  • src/components/editors/filters/FilterBuilderPro/components/FilterBuilderItem.tsx
  • src/components/editors/filters/FilterBuilderPro/index.tsx
  • src/components/editors/filters/FilterBuilderWithGroupingPro/components/FilterBuilderWithGroupingGroup.tsx
  • src/components/editors/filters/FilterBuilderWithGroupingPro/components/FilterBuilderWithGroupingItem.tsx
  • src/components/editors/filters/FilterBuilderWithGroupingPro/index.tsx
  • src/components/editors/filters/components/FilterBuilderItemValueField.tsx
  • src/components/editors/shared/DimensionAndMeasureSingleSelectField/DimensionAndMeasureSingleSelectField.tsx
  • src/theme/i18n/translations/de.ts
  • src/theme/i18n/translations/en.ts
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@mad-raccoon mad-raccoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need to release the RUI, and update the version on this repo

@mad-raccoon
mad-raccoon marked this pull request as ready for review September 17, 2026 16:51
@mad-raccoon
mad-raccoon merged commit 5e77cf6 into main Sep 17, 2026
2 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants