Raise ArgumentError for multiple :auto dimensions in reshape - #1819
Merged
Conversation
Nx.reshape with more than one :auto leaked a bare ArithmeticError: after resolving the first :auto, Tuple.product multiplied by the second :auto atom. Now raises a descriptive ArgumentError. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
this one is more opinionated, but covers a uncovered and unintentional error that would be confusing to run into in the wild |
polvalente
approved these changes
Aug 17, 2026
polvalente
left a comment
Member
There was a problem hiding this comment.
Maybe worth a pass in Nx.revectorize :target_shape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nx.reshapewith more than one:autodimension leaked a bareArithmeticError: after resolving the first:auto,Tuple.productmultiplied by the second:autoatom.🤖 Generated with Claude Code