Skip to content

Render an invite that arrives as a timeline member event as an invite push - #7208

Open
ara4n wants to merge 1 commit into
developfrom
matthew/knock-accepted-push-copy-pr
Open

Render an invite that arrives as a timeline member event as an invite push#7208
ara4n wants to merge 1 commit into
developfrom
matthew/knock-accepted-push-copy-pr

Conversation

@ara4n

@ara4n ara4n commented Jul 14, 2026

Copy link
Copy Markdown
Member

An invite for the current user can resolve as a timeline member event rather than a stripped invite when the room has already advanced past the invited state by notification-resolution time — e.g. the server auto-joined the user because their knock was accepted (element-hq/synapse#16307). Such invites were filtered out of notifications entirely; render them with the normal invite copy instead.

Tests

e2e rig flow 10

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 17

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

… push

An invite for the current user can resolve as a timeline member event
rather than a stripped invite when the room has already advanced past
the invited state by notification-resolution time — e.g. the server
auto-joined the user because their knock was accepted
(element-hq/synapse#16307). Such invites were filtered out of
notifications entirely; render them with the normal invite copy instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uk8aPxHn3BHCe52L226jdG
@ara4n
ara4n requested a review from a team as a code owner July 14, 2026 17:18
@ara4n
ara4n requested review from bmarty and removed request for a team July 14, 2026 17:18
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant