Conversation
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
|
Friendly ping for review @elastic/integrations-triaging |
jsoriano
left a comment
There was a problem hiding this comment.
LGTM as initial version.
Would it be possible to add tests?
Policy tests should be easy to add and they would be specially relevant now that we are stabilizing latest changes in Fleet for OTel integrations, and I think this one would be the first one for profiles.
|
I have skipped tests, as they fail with an error that seems unrelevant to the package: This package does not set or define datastreams. |
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
| exporters: | ||
| elasticsearch/componentid-0: | ||
| auth: | ||
| authenticator: beatsauth/default |
There was a problem hiding this comment.
🟢 Low policy/test-with-samples-per-second.expected:6
The elasticsearch/componentid-0 exporter references beatsauth/default (line 6), but no extension by that name exists. The actual extension defined is beatsauth/componentid-0 (line 10), and that's what's registered in service.extensions (line 42). This mismatch causes the OpenTelemetry Collector configuration validation to fail at startup with an unknown extension reference error.
| authenticator: beatsauth/default | |
| authenticator: beatsauth/componentid-0 |
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file packages/profiling_otel/_dev/test/policy/test-with-samples-per-second.expected around line 6:
The `elasticsearch/componentid-0` exporter references `beatsauth/default` (line 6), but no extension by that name exists. The actual extension defined is `beatsauth/componentid-0` (line 10), and that's what's registered in `service.extensions` (line 42). This mismatch causes the OpenTelemetry Collector configuration validation to fail at startup with an unknown extension reference error.
There was a problem hiding this comment.
@elastic/integrations-triaging is this expected?
There was a problem hiding this comment.
This is expected, but for the fingerprint diff found in CI you will have to wait for a release of elastic-package with elastic/elastic-package#3467 (coming soon).
To unblock this skip the policy test by now, and we will remove the skip after releasing the next elastic-package version.
There was a problem hiding this comment.
not sure if c5d8f8a is the correct way to skip this test. looking at other packages this seems to be the only way - didn't find documentation.
💚 Build Succeeded
History
|
Proposed commit message
Add new OTel profiling input integration.
Checklist
changelog.ymlfile.