fix: reject invalid Linux core ids#12
Open
Sieger9303 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #11.
Hi, thanks for maintaining this crate.
set_thread_affinitycurrently passes each user-provided core id directly toCPU_SET. On Linux, very large invalid core ids can makeCPU_SETindex outside the backingcpu_set_tstorage and panic beforesched_setaffinityhas a chance to return an error.This PR adds a bounds check before calling
CPU_SET, returning anErrfor invalid core ids instead of panicking. =