feat: back up several mongo databases in one run - #81
Open
BetoFandino wants to merge 1 commit into
Open
BetoFandino wants to merge 1 commit into
BetoFandino wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mongodump only takes a single --db, so mongo_backup could only ever dump one database when MONGO_BACKUP_ALL_DATABASES was false. Add MONGO_BACKUP_DATABASES, which takes any number of databases and runs one dump per entry, uploading one archive for each. MONGO_BACKUP_DATABASE keeps working and is read as a single element list.
An archive holding a single database is now named after it (_mongo_edxapp.gz), since storage_backups uploads by basename and every database would otherwise overwrite the same object. Archives taken with MONGO_BACKUP_ALL_DATABASES set to true keep the _mongo.gz name, so the inventories using it are unaffected.
mongo_restore reads that name through the new MONGO_RESTORE_ARCHIVE_NAME, and mongo_clone passes it so backup and restore keep pointing at the same file.