Skip to content

Blink: add report-only errors parity CI job - #415

Merged
TomasVotruba merged 1 commit into
mainfrom
blink-report-only-parity
Nov 20, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
blink-report-only-parity

Conversation

@TomasVotruba

@TomasVotruba TomasVotruba commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Blink already reports errors of report-only sniffs and exits non-zero without fixing, same as ECS. This adds a CI job proving it stays that way, and fixes the divergences it found.

  • blink/cmd/list-reporters - prints every rule implementing fixer.ErrorReporter (85 now)
  • blink/parity/errors.sh <corpus.json> - runs all of them in check mode on a corpus, with --blink and with the PHP engine, compares reported errors (file, line, checker, message) and exit codes; any difference fails
  • new errors-parity job in blink_parity.yaml on rector-src and mautic

Fixes for false positives found on mautic:

  • use function / use const (and inside use groups) are T_STRING in PHPCS, not T_FUNCTION / T_CONST - CamelCapsFunctionName and both ValidFunctionName sniffs reported them
  • DisallowMultipleAssignments treated an open short array like T_OPEN_SQUARE_BRACKET, reporting foo([$x = new Y()])
  • NestingLevel counted levels from the scope list instead of the PHPCS level map

Local run: rector-src 24914 errors, mautic 104822 errors, identical to ECS, both exit 2.

@TomasVotruba
TomasVotruba force-pushed the blink-report-only-parity branch from dcb8af9 to f4fbe30 Compare November 20, 2026 10:26
…ion imports, short-array assignments and nesting levels
@TomasVotruba
TomasVotruba force-pushed the blink-report-only-parity branch from f4fbe30 to ab8b30e Compare November 20, 2026 10:27
@TomasVotruba
TomasVotruba merged commit 0d6ca3d into main Nov 20, 2026
14 checks passed
@TomasVotruba
TomasVotruba deleted the blink-report-only-parity branch November 20, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant