Repository navigation
Blink: add report-only errors parity CI job - #415
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
blink-report-only-parity
branch
from
November 20, 2026 10:26
dcb8af9 to
f4fbe30
Compare
…ion imports, short-array assignments and nesting levels
TomasVotruba
force-pushed
the
blink-report-only-parity
branch
from
November 20, 2026 10:27
f4fbe30 to
ab8b30e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blink already reports errors of report-only sniffs and exits non-zero without fixing, same as ECS. This adds a CI job proving it stays that way, and fixes the divergences it found.
blink/cmd/list-reporters- prints every rule implementingfixer.ErrorReporter(85 now)blink/parity/errors.sh <corpus.json>- runs all of them in check mode on a corpus, with--blinkand with the PHP engine, compares reported errors (file, line, checker, message) and exit codes; any difference failserrors-parityjob inblink_parity.yamlon rector-src and mauticFixes for false positives found on mautic:
use function/use const(and inside use groups) areT_STRINGin PHPCS, notT_FUNCTION/T_CONST- CamelCapsFunctionName and both ValidFunctionName sniffs reported themT_OPEN_SQUARE_BRACKET, reportingfoo([$x = new Y()])Local run: rector-src 24914 errors, mautic 104822 errors, identical to ECS, both exit 2.