Repository navigation
Blink: port the fixable slevomat Exceptions, Numbers, Variables and Whitespaces sniffs - #414
Merged
Merged
Conversation
…hitespaces sniffs Ports CatchExceptionsOrder, ReferenceThrowableOnly, RequireNonCapturingCatch, DisallowNumericLiteralSeparator, UselessVariable and DuplicateSpaces, verified on golden outputs generated by ECS from the upstream test fixtures.
TomasVotruba
force-pushed
the
blink-slevomat-small
branch
from
November 20, 2026 10:09
502f67e to
94cd5b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fixable sniffs of four small slevomat categories to blink, following #410 (Namespaces).
caseSensitiveenableignoreSpacesBeforeAssignment,ignoreSpacesInAnnotation,ignoreSpacesInComment,ignoreSpacesInParameters,ignoreSpacesInMatchTests
exceptionReferences*fixtures have goldens although upstream has no.fixed.php: upstream only asserts the reported errors, ECS fixes them.Parity with ECS
Every sniff (all DuplicateSpaces configs, CatchExceptionsOrder
caseSensitive) was run by ECS and by blink on Laravelsrc, clean and with mutations targeting it: shuffled multi-catches, unused / later-used / closure-captured / interpolated catch variables,\Exceptionin parameters, unions and returns,@phpcsSuppress, numeric separators in every literal form,$x = ...; return $x;templates, doubled spaces and mid-line tabs in code, comments, docblocks, strings and heredocs.Output is byte-identical everywhere except files where upstream produces invalid PHP, which blink's lint guard reverts:
\Throwable|\Throwable(8 mutated files).$x = &$y; return $x;intoreturn &$y;(one mutation template).Without the lint guard blink's output equals ECS on those files too.