Refactor controller - #4541
Open
honeyverma1 wants to merge 1 commit into
Open
Refactor controller#4541honeyverma1 wants to merge 1 commit into
honeyverma1 wants to merge 1 commit into
Conversation
honeyverma1
requested review from
GMishx,
KoukiHama,
ag4ums,
arunazhakesan and
rudra-superrr
as code owners
August 30, 2026 16:10
Member
|
@saad-mohammed1 , can you please help review and test this PR? @honeyverma1 , this PR now has conflicts. Please rebase with latest main to avoid unnecessary commits and keep our history clean. |
honeyverma1
force-pushed
the
refactor_controller
branch
from
September 20, 2026 18:47
a47e265 to
482024d
Compare
honeyverma1
force-pushed
the
refactor_controller
branch
from
September 20, 2026 19:04
482024d to
f4b7f09
Compare
Author
|
rebase done. and the conflicts have also been resolved. please take a look |
Contributor
|
Sure.. @GMishx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The issue states that the ReleaseController is oversized and is performing more activities than a REST controller actually should. Thus this PR is an attempt to reduce the functionality of the ReleaseController and to only handle REST APIs.
Issue:
Suggest Reviewer
@GMishx @rudra-superrr @akshitjoshii
Must I say I have very little knowledge regarding the licencing of a class, Both the new classes proposed contain the same licence as ReleaseController with the current year.
Please let me know if anything needs to change or if there is any issue with the proposed changes.
Thank you.