Skip to content

Refactor controller - #4541

Open
honeyverma1 wants to merge 1 commit into
eclipse-sw360:mainfrom
honeyverma1:refactor_controller
Open

honeyverma1 wants to merge 1 commit into
eclipse-sw360:mainfrom
honeyverma1:refactor_controller

Conversation

@honeyverma1

Copy link
Copy Markdown

This PR is aimed at solving the issue #3907

Summary

The issue states that the ReleaseController is oversized and is performing more activities than a REST controller actually should. Thus this PR is an attempt to reduce the functionality of the ReleaseController and to only handle REST APIs.

Functionalities shifted to another class
Primarily, 3 different functions were removed from the original functioin and has been shifted to new classes namely ReleaseRequestMapper which now implements the function setBackwardCompatibleFieldsInRelease(), and ReleaseModelAssembler which implements the function createHalReleaseResource() and createHalReleaseResourceWithAllDetails().
I have simply shifted all these functions to different classes and introduced 2 new dependencies in the original ReleaseController.

Issue:

Suggest Reviewer

@GMishx @rudra-superrr @akshitjoshii

Must I say I have very little knowledge regarding the licencing of a class, Both the new classes proposed contain the same licence as ReleaseController with the current year.

Please let me know if anything needs to change or if there is any issue with the proposed changes.
Thank you.

@GMishx

GMishx commented Sep 19, 2026

Copy link
Copy Markdown
Member

@saad-mohammed1 , can you please help review and test this PR?

@honeyverma1 , this PR now has conflicts. Please rebase with latest main to avoid unnecessary commits and keep our history clean.

@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for has merge conflicts The PR has merge conflicts labels Sep 19, 2026
@honeyverma1

Copy link
Copy Markdown
Author

rebase done. and the conflicts have also been resolved. please take a look

@saad-mohammed1

Copy link
Copy Markdown
Contributor

Sure.. @GMishx!
Iam Testing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has merge conflicts The PR has merge conflicts needs code review needs general test This is general testing, meaning that there is no org specific issue to check for

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants