Add opt-in timing tests for the compare editor open path#2799
Open
vogella wants to merge 1 commit into
Open
Conversation
CompareOpenPerformanceTest measures wall time from opening a compare editor until the text is visible and until the diff is reported, for several synthetic file sizes and change densities, plus a unified diff scenario and a headless DocumentMerger microbenchmark. Each scenario is repeated, warmup repetitions are discarded, and the median is printed as a greppable PERF line and written to a CSV; only a generous sanity bound is asserted, so shared CI timing noise cannot produce spurious failures. RangeDifferencerTest is migrated off the retired org.eclipse.test.performance database harness, which asserted nothing without a baseline database, onto the same repeated-run median pattern while keeping its correctness assertions. The suite is intentionally not part of AllCompareTests; it runs on demand via PerformanceTestSuite. Contributes to eclipse-platform#2795
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds CompareOpenPerformanceTest, which measures the wall time from opening a compare editor until the text is visible and until the diff is reported, over several synthetic sizes and change densities, plus a unified diff scenario and a headless DocumentMerger microbenchmark. Repeated runs with warmup and median reporting produce stable, greppable PERF lines and a CSV instead of fragile timing thresholds; only a generous sanity bound is asserted. The suite is intentionally not part of AllCompareTests and runs on demand via -DtestClass=org.eclipse.compare.tests.performance.PerformanceTestSuite, so the default CI run is unaffected; it serves as the yardstick for the follow-up optimizations of the linked issue. RangeDifferencerTest is migrated off the retired org.eclipse.test.performance harness, which asserts nothing without its baseline database, onto the same pattern while keeping its correctness assertions, and the now unused dependency is removed from the test bundle. Current baseline on Linux: opening a 5000 line compare with 100 changes takes about 190 ms, with time to text equal to time to diff, confirming that nothing is shown until the diff completes.
Contributes to #2795