Switch to Platform.getDebugBoolean(String) where appropriate#2785
Open
ptziegler wants to merge 1 commit into
Open
Switch to Platform.getDebugBoolean(String) where appropriate#2785ptziegler wants to merge 1 commit into
Platform.getDebugBoolean(String) where appropriate#2785ptziegler wants to merge 1 commit into
Conversation
Contributor
Test Results 36 files - 18 36 suites - 18 34m 4s ⏱️ - 25m 26s Results for commit 443331b. ± Comparison against base commit 6bef442. This pull request skips 25 tests.♻️ This comment has been updated with latest results. |
Contributor
|
LGTM |
With 3b76d20, a convenience method `getDebugBoolean(String)` was added, which returns `true` if the given tracing option is enabled. Using this method avoids a lot of the boilerplate code that comes with using `getDebugOption(String)` and which usually looks something like: `"true".equals(Platform.getDebugOption("..."))`
ptziegler
force-pushed
the
use-get-debug-boolean
branch
from
ab412d7 to
443331b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 3b76d20, a convenience method
getDebugBoolean(String)was added, which returnstrueif the given tracing option is enabled. Using this method avoids a lot of the boilerplate code that comes with usinggetDebugOption(String)and which usually looks something like:"true".equals(Platform.getDebugOption("..."))