feat: SQL persistence layer#80
Merged
ronjaquensel merged 9 commits intoMay 26, 2026
Merged
Conversation
ndr-brt
reviewed
May 25, 2026
|
|
||
| protected Connection getConnection() { | ||
| try { | ||
| return DriverManager.getConnection(databaseUrl, databaseUsername, databasePassword); |
Contributor
There was a problem hiding this comment.
this makes me think that we should create a refactor issue to permit to setup an external connection pool if needed (very likely in any production environment)
Contributor
Author
There was a problem hiding this comment.
Yes, was thinking about that as well. Will create a follow-up issue once this PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SQL stores for data flows and control planes. Creation of the SQL statements is handled by dedicated interfaces which are currently implemented for Postgres, but could be implemented for different SQL dialects. Also adds store tests, which are run for both in-memory and Postgres implementations to ensure equivalent behaviour. The e2e tests still use the in-memory stores, but could also be shifted to use Postgres in the future.
The SQL stores are added to the main module for now, but could be moved to a separate module in a subsequent PR.
Closes #52