Combine layer and model editors; fix issues in lists#303
Open
rozyczko wants to merge 7 commits into1.2.0_fixes2from
Open
Combine layer and model editors; fix issues in lists#303rozyczko wants to merge 7 commits into1.2.0_fixes2from
rozyczko wants to merge 7 commits into1.2.0_fixes2from
Conversation
combine layer editor with model editor
rozyczko
added
[scope] bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix branch for Sample tab lists behaving incorrectly on subsequent clicks on rows.
This pull request adds new methods and corresponding UI wiring to allow setting properties (such as name, thickness, roughness, material, etc.) of materials, models, assemblies, and layers by their index, not just by the currently selected item.
The most important changes are:
Backend logic enhancements:
Added
set_*_at_indexmethods to logic classes (material.py,models.py,assemblies.py,layers.py) to allow updating properties (e.g., name, SLD, ISLD, thickness, roughness, material, solvent, formula, APM, solvation) of items at a specific index, returning a boolean to indicate if a change occurred.Updated the main backend interface (
sample.py) to expose new slot methods for these per-index setters, emitting the appropriate change signals so the UI updates correctly.Frontend/UI integration:
Added new methods into the QML backend wrapper (
BackendWrapper.qml), making them available to the UI layer for direct invocation from QML.Updated UI components (e.g.,
MultiLayer.qml) to use the new per-index setter functions, ensuring that edits in tables or lists update the correct item regardless of selection.