Add throttle settings (throttle_attribute, node/shared throttle limit…#8
Open
LilyCaroline17 wants to merge 1 commit into
Open
Conversation
…s) to WorkloadGroup construct Signed-off-by: Emily Guo <35637792+LilyCaroline17@users.noreply.github.com>
4ae1f72 to
b6244e8
Compare
b6244e8 to
a7bd18c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds throttle configuration fields to the WorkloadGroup construct as the foundational layer for WLM Request Throttling (# 21064). This PR introduces and persists the settings on the workload group construct.
Fields: Added 3 fields to the workload group construct
All three are optional. The total cluster-wide ceiling is node_throttle_limit × N + shared_throttle_limit.
Example
Update / clear semantics
Throttle fields follow three-way merge semantics on update:
Validation
throttle_attribute is currently stored as an opaque non-blank string; it is not yet validated against the WLM attribute registry (index_pattern, principal.username, principal.role). Will complete in a later PR
Testing
Added unit tests in WorkloadGroupTests. Manually verified end-to-end against a live single-node cluster (./gradlew :run -PinstalledPlugins="['workload-management']", WLM mode enabled): create, GET, merge-update, clear-via-null, and all four validation rejections behave as expected.
Related Issues
Resolves # 21064
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.