fix: support user account all-target runs#5
Merged
Merged
Conversation
Member
Author
|
Final report:
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened on behalf of Onur Solmaz (
osolmaz).Summary
github-sane-defaults plan OWNER --allonly worked for organizations.User accounts were routed through the organization repositories endpoint and failed with a 404.
This change makes
--allowner-aware, so the same command works for both organizations and user accounts.What Changed
The CLI now treats targets as owners instead of organizations internally.
It keeps
--orgas a compatibility alias and adds--owneras the clearer spelling.GET /users/{owner}and branch on the GitHub accounttype./orgs/{org}/repos?type=allfor organization owners./user/repos?visibility=all&affiliation=owner,collaboratorfor user owners, then filter byrepo.owner.login.Linkheaders.orgtoowner.Testing
I tested the parser, planner, apply path, REST client behavior, docs conventions, and a live plan-only user-account scan.
The live scan verified that
osolmaz --allno longer calls the organization-only endpoint.npm run checknpx -y @simpledoc/simpledoc checkgit diff --checknode dist/src/cli/main.js plan osolmaz --all --token "$(gh auth token)"Risks
The main behavior change is limited to repository discovery for
--all.Single-repository targets continue to use the same
/repos/{owner}/{repo}path.--orgremains supported for existing automation.