Fix slow os.walk -> faster os.scandir#1
Open
vithursant wants to merge 2 commits into
Open
Conversation
dukebw
reviewed
Aug 9, 2019
| num_ex = len(os.listdir(root)) | ||
| print(root, num_ex) | ||
| for root in os.scandir(d): | ||
| if root.is_dir(): |
Owner
There was a problem hiding this comment.
should this be assert root.is_dir()? Seems like if that's not true then (I meant fnames won't be set)*.
Owner
There was a problem hiding this comment.
Just seems odd that fnames is not set if this branch isn't hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.walk is currently quite slow because it first lists the directory and then does a stat on each entry to see if it is a directory or a file.
switched to os.scandir() originally written by Ben Hoyt (see https://benhoyt.com/writings/scandir/).