Repository navigation
fix(package): [random] handle non-positive unique slice lengths - #402
Merged
duke-git merged 1 commit intoOct 22, 2026
Merged
Conversation
duke-git
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle non-positive lengths in the two unique random-slice helpers before allocating. This matches
RandIntSlice,RandBoolSliceandRandStringSlice; negative requests currently panic.The regression panics before the fix. Random tests, vet and gofmt pass on Windows/Go 1.27.0, covering zero and negative lengths. The repository-wide test command encounters unrelated existing Windows/process/crypto fixture failures.