Fix parsing of double indexes#12
Open
kyleadams-nflx wants to merge 7 commits into
Open
Conversation
…-and-objects' into netflix
Fixes for netflix
remove debug statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR handles cases where a resource address contained two indexes:
module.mymodule.module.submodule[0].data.subsubmodule.this[0]the code only handled addresses that contained one index, so any plan with two produced this error:
failed to parse resource info from address module.mymodule.module.submodule[0].data.subsubmodule.this[0]Note: this pulls in the other two PR's, so probably best to merge those and then rebase before looking at this one.