Skip to content

Fix note height jitter when editing from the side panel #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1ilit merged 1 commit into from
Nov 12, 2026
Merged

Fix note height jitter when editing from the side panel #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/EditorCanvas/Note.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export default memo(function Note({ data, onPointerDown }) {
if (newHeight === data.height) return;

updateNote(data.id, { height: newHeight });
}, [data.id, data.width, data.height, updateNote]);
}, [data.id, data.width, data.height, data.content, updateNote]);

return (
<g
Expand Down
6 changes: 1 addition & 5 deletions src/components/EditorSidePanel/NotesTab/NoteInfo.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,7 @@ export default function NoteInfo({ data, nid }) {
autosize
readonly={layout.readOnly}
onChange={(value) => {
const textarea = document.getElementById(`note_${data.id}`);
textarea.style.height = "0";
textarea.style.height = textarea.scrollHeight + "px";
const newHeight = textarea.scrollHeight + 16 + 20 + 4;
updateNote(data.id, { height: newHeight, content: value });
updateNote(data.id, { content: value });
}}
onFocus={(e) =>
setEditField({ content: e.target.value, height: data.height })
Expand Down
Loading