Linux build & smoke test fixes for the release workflow#95
Open
ruokun-niu wants to merge 7 commits intodrasi-project:mainfrom
Open
Linux build & smoke test fixes for the release workflow#95ruokun-niu wants to merge 7 commits intodrasi-project:mainfrom
ruokun-niu wants to merge 7 commits intodrasi-project:mainfrom
Conversation
Signed-off-by: ruokun-niu <ruokunniu@gmail.com>
Signed-off-by: ruokun-niu <ruokunniu@gmail.com>
Signed-off-by: ruokun-niu <ruokunniu@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow and cross-compilation environment to fix Linux (gnu + musl) builds and make the post-build “hello-world” smoke test succeed by ensuring required plugins are available and compatible.
Changes:
- Update cross-compilation Dockerfiles (notably moving to Ubuntu 22.04 and adjusting toolchain/build deps) to resolve GLIBC/bindgen-related build failures.
- Update the release workflow to install
crossfrom git and pre-install required plugins before running the hello-world smoke test across platforms. - Bump Drasi host/plugin dependencies to match published plugin compatibility and adjust the integration test config accordingly.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/hello-world/config.yaml | Aligns hello-world integration config with smoke-test plugin expectations (adds verification toggle + rationale comment). |
| Dockerfile.cross-musl-aarch64 | Updates musl aarch64 cross toolchain base image selection. |
| Dockerfile.cross-musl | Reworks musl x86_64 cross build container (Ubuntu 22.04 base + bindgen/include fixes + toolchain env). |
| Dockerfile.cross-gnu-aarch64 | Updates gnu aarch64 cross toolchain base image selection. |
| Dockerfile.cross-gnu | Updates gnu x86_64 cross toolchain base image selection. |
| Cargo.toml | Bumps Drasi crate versions to match plugin compatibility requirements. |
| Cargo.lock | Locks updated dependency graph for the bumped Drasi crates. |
| .github/workflows/release.yaml | Adjusts Linux build to install cross from git and pre-installs required plugins for smoke tests (Unix/Alpine/Windows). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| FROM ghcr.io/cross-rs/aarch64-unknown-linux-gnu:0.2.5 AS toolchain | |||
| FROM ghcr.io/cross-rs/aarch64-unknown-linux-gnu:main AS toolchain | |||
Comment on lines
+1
to
+6
| FROM ghcr.io/cross-rs/x86_64-unknown-linux-musl:main AS toolchain | ||
|
|
||
| # Use Ubuntu 22.04 (glibc 2.35) as the runtime base so build-script binaries | ||
| # produced by modern rustc (which require GLIBC_2.34) can execute. The cross-rs | ||
| # musl image is used only as a source for the musl cross-toolchain. | ||
| FROM ubuntu:22.04 |
Signed-off-by: ruokun-niu <ruokunniu@gmail.com>
agentofreality
approved these changes
May 6, 2026
Signed-off-by: ruokun-niu <ruokunniu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linux build & smoke test fixes
Cross-compile (Dockerfiles)
Dockerfile.cross-{gnu,gnu-aarch64,musl,musl-aarch64}from Ubuntu 20.04 (EOL repos) to 22.04.clang+libclang-devsobindgen/zstd-sysfindstddef.h.Smoke test (
.github/workflows/release.yaml)plugin install source/mockandplugin install reaction/logsteps (with--skip-verification) before the hello-world smoke test on Linux, Alpine/musl, and Windows, populatingbin/plugins/.Test config
tests/integration/hello-world/config.yamlto match the smoke runner (mock source + log reaction loaded frombin/plugins).Plugin compatibility (
Cargo.toml/Cargo.lock)Bumped host deps to match the latest plugins on
ghcr.io/drasi-project:drasi-host-sdk0.6.0 → 0.6.2drasi-lib0.6.0 → 0.6.1drasi-core0.4.2 → 0.4.3Without this bump the resolver rejected published plugins as incompatible.
Result
Linux GNU + musl cross builds succeed, and the post-build smoke test passes on Linux, macOS, and Windows.
Type of change
Fixes: #issue_number