Skip to content

Consumer: replace client.poll with manager.run for metadata refresh waits #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
May 7, 2026
+6 −4
Merged

Consumer: replace client.poll with manager.run for metadata refresh waits #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kafka/consumer/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,11 +619,11 @@ def _fetch_all_topic_metadata(self):
cluster = self._client.cluster
if cluster.metadata_refresh_in_progress:
future = cluster.request_update()
self._client.poll(future=future)
self._manager.run(self._manager.wait_for, future, None)
stash = cluster.need_all_topic_metadata
cluster.need_all_topic_metadata = True
future = cluster.request_update()
self._client.poll(future=future)
self._manager.run(self._manager.wait_for, future, None)
cluster.need_all_topic_metadata = stash

def topics(self):
Expand Down
6 changes: 4 additions & 2 deletions kafka/coordinator/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,10 @@ def poll(self, timeout_ms=None):
# description of the problem.
if self._subscription.subscribed_pattern:
metadata_update = self._client.cluster.request_update()
self._client.poll(future=metadata_update, timeout_ms=timer.timeout_ms)
if not metadata_update.is_done:
try:
self._manager.run(
self._manager.wait_for, metadata_update, timer.timeout_ms)
except Errors.KafkaTimeoutError:
log.debug('coordinator.poll: timeout updating metadata; returning early')
return False

Expand Down
Loading