lib-storage: mailbox-list - Track hierarchy part start using ns_sep#302
Open
nishat-06 wants to merge 1 commit into
Open
lib-storage: mailbox-list - Track hierarchy part start using ns_sep#302nishat-06 wants to merge 1 commit into
nishat-06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mailbox_list_escape_name_params_to_str() tracks the start of a hierarchy part with a hardcoded '/', so when the caller passes a different ns_sep the "." and ".." checks in need_escape_dirstart() are skipped for every part after the first. imapc passes the remote server's announced LIST separator here along with the remote mailbox name, so a backend using ':' can return "..:..:etc" and get "../../etc" back as the local storage and fs name. Track the part start with ns_sep too, and use that same terminator test inside need_escape_dirstart().